Adding Dirichlet and SimplexTransform to pymc.dims#7921
Merged
zaxtax merged 2 commits intopymc-devs:mainfrom Oct 23, 2025
Merged
Adding Dirichlet and SimplexTransform to pymc.dims#7921zaxtax merged 2 commits intopymc-devs:mainfrom
zaxtax merged 2 commits intopymc-devs:mainfrom
Conversation
ricardoV94
approved these changes
Oct 7, 2025
Member
|
If you rebase from main it shuold pick the newer PyTensor with the xtensor function you need |
e8f0025 to
4c95389
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7921 +/- ##
==========================================
+ Coverage 89.33% 91.47% +2.14%
==========================================
Files 116 116
Lines 18904 18939 +35
==========================================
+ Hits 16887 17325 +438
+ Misses 2017 1614 -403
🚀 New features to boost your workflow:
|
Contributor
Author
|
@ricardoV94 the failing test seems unrelated to my PR |
Member
|
Yes it is not, it's a warning that's no longer emitted in the latest PyTensor. Can you remove it in a separate commit? |
77d39f7 to
bb3e008
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the Dirichlet distributions in
pymc.dimsRelated Issue
This depends on pymc-devs/pytensor#1629 to get merged
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7921.org.readthedocs.build/en/7921/