Skip to content

Make sure a tool table is created in toml generation#8638

Merged
DanielNoord merged 3 commits intopylint-dev:mainfrom
DanielNoord:tomlkit
Apr 30, 2023
Merged

Make sure a tool table is created in toml generation#8638
DanielNoord merged 3 commits intopylint-dev:mainfrom
DanielNoord:tomlkit

Conversation

@DanielNoord
Copy link
Copy Markdown
Collaborator

Type of Changes

Type
🐛 Bug fix

Description

Reverts #8633
Fixes #8632

@DanielNoord DanielNoord added dependency Label for github dependabot backport maintenance/4.0.x labels Apr 30, 2023
@DanielNoord DanielNoord added this to the 2.17.4 milestone Apr 30, 2023
@DanielNoord DanielNoord added the Skip news 🔇 This change does not require a changelog entry label Apr 30, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 30, 2023

Codecov Report

Merging #8638 (2d97d0b) into main (1cbc3d8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8638   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files         174      174           
  Lines       18319    18321    +2     
=======================================
+ Hits        17552    17554    +2     
  Misses        767      767           
Impacted Files Coverage Δ
pylint/config/arguments_manager.py 100.00% <100.00%> (ø)

Copy link
Copy Markdown
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the "real" fix :D

@DanielNoord DanielNoord enabled auto-merge (squash) April 30, 2023 15:26
@DanielNoord DanielNoord merged commit 434d49f into pylint-dev:main Apr 30, 2023
@DanielNoord DanielNoord deleted the tomlkit branch April 30, 2023 15:32
github-actions bot pushed a commit that referenced this pull request Apr 30, 2023
Co-authored-by: Pierre Sassoulas <[email protected]>
(cherry picked from commit 434d49f)
Pierre-Sassoulas pushed a commit that referenced this pull request Apr 30, 2023
…8640)

Co-authored-by: Pierre Sassoulas <[email protected]>
(cherry picked from commit 434d49f)

Co-authored-by: Daniël van Noord <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backported dependency Label for github dependabot Skip news 🔇 This change does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TOMLKitError when generating TOML config with tomlkit 0.11.8

2 participants