False positive for "bad-continuation"

[pylint-bot]

Originally reported by: Steven Myint (BitBucket: myint, GitHub: @myint?)

---

This valid style is incorrectly labeled as bad-continuation.

def test():
    if (
        True or
        False
    ):
        pass

C:  3, 0: Wrong hanging indentation before block.
        True or
        ^   | (bad-continuation)
C:  4, 0: Wrong hanging indentation before block.
        False
        ^   | (bad-continuation)

As described in #232, there are more false positives demonstrated in E12not.py.

---

• Bitbucket: https://bitbucket.org/logilab/pylint/issue/289

[pylint-bot]

Original comment by Niklas Hambüchen (BitBucket: nh2, GitHub: @nh2?):

---

Relatedly, which of these two is correct?

#!python


for x in [
  1,
  2,
  ]:
  print x

for x in [
    1,
    2,
  ]:
  print x

Pylint 1.4 says that the upper one is correct and the lower one is wrong; can you tell me whether that's true according to PEP8?

(Of course assuming I'm working with indent-string = " " and indent-after-paren = 2.)

[pylint-bot]

Original comment by Olegs Jeremejevs (BitBucket: jeremejevs, GitHub: @jeremejevs?):

---

Similarly, the following gets labeled as bad-continuation as well:

#!python

for x in [
    1,
    2
]:
    pass

[pylint-bot]

Original comment by Steven Myint (BitBucket: myint, GitHub: @myint?):

---

def test():
    if (
        True or
        False
    ):
        pass

c00365b shows what is happening in more detail. It looks like it wants the thing to be doubly indented for some reason.

C:  3, 0: Wrong hanging indentation before block (add 4 spaces).
        True or
        ^   | (bad-continuation)
C:  4, 0: Wrong hanging indentation before block (add 4 spaces).
        False
        ^   | (bad-continuation)

That would look odd:

def test():
    if (
            True or
            False
    ):
        pass

[pylint-bot]

Original comment by Debanshu Kundu (BitBucket: debanshuk, GitHub: @debanshuk?):

---

I am forced to use pylint-1.1.0 (instead of latest the 1.4.3), due to this bug.

Following is another example of false positive for 'bad-continuation':

#!python

def abc(
    arg1,
    arg2
):
    pass

Only the following should be reported as 'bad-continuation' and not the one above.

#!python

def abc(
    arg1,
    arg2
    ):
    pass

[mjrk]

+1

At least, it would be very nice to have a way to disable these checks (so they are covered by pep8)

[allan-simon]

Is this bug hard to fix, does someone has some hint on where the bug may be located ?

Just to know if it's something one's can easily try to fix, or if it requires deep knowledge of the codebase.

[fgimian]

I found that I could disable this using code C0330 and use pep8 (or flake8) for this particular check 😄

Hope this helps
Fotis

[radeklat]

This bug is really annoying. It forces me to turn off C0330. But I suppose if it hasn't been fixed in 4 year, it won't be fixed at all...

[PCManticore]

At this point you might just use black and disable pylint's formatting altogether. Or wait until we'll get to it, or send a patch. Lots of solutions .:)