Skip to content

Fix dependency_list not being transferred #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-janssen merged 1 commit into from
May 2, 2023
Merged

Fix dependency_list not being transferred #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pysqa/queueadapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ def submit_job(
cores=cores,
memory_max=memory_max,
run_time_max=run_time_max,
dependency_list=dependency_list,
command=command,
)

Expand Down
4 changes: 4 additions & 0 deletions tests/test_queueadapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,10 @@ def test_check_queue_parameters(self):
def test_queue_view(self):
self.assertIsInstance(self.slurm.queue_view, pandas.DataFrame)

def test_submit_job_remote(self):
with self.assertRaises(NotImplementedError):
self.remote.submit_job(queue="remote", dependency_list=[])

def test_memory_string_comparison(self):
self.assertEqual(BasisQueueAdapter._value_in_range(1023, value_min="1K"), "1K")
self.assertEqual(BasisQueueAdapter._value_in_range(1035, value_min="1K"), 1035)
Expand Down