Use a polling thread per device#778
Merged
Merged
Conversation
Korijn
previously approved these changes
Nov 21, 2025
Korijn
reviewed
Nov 21, 2025
Member
Author
|
I don't think anyone uses feature to set the loop yet, but just in case, let's merge this after pygfx/rendercanvas#146 is merged. |
Member
Author
|
I made a small improvement to the I can already see that the FPS in pygfx/rendercanvas#138 increases a bit because the system simply reacts immediately (instead of the previous loop that repeatedly sleeps and checks status). Also, while FPS is nice, the greater advantage IMO is minimizing the delay between rendering a frame and putting it under the user's eyes. This delay has a big impact on the perceived responsiveness. |
Korijn
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes each device create a thread for polling the native device to resolve the promises. This means there are no busy-loops; i.e. its less strain on the CPU while obtaining faster responses.
The implemented technique is heavily inspired by the implementation in the Servo browser (servo/servo#32266). The Firefox browser will likely adopt a similar strategy soon (https://bugzilla.mozilla.org/show_bug.cgi?id=1870699).
When passing a loop instance, this work relies on
loop.call_soon_threadsafefrom pygfx/rendercanvas#146.