Implemented sparse variant of top-k sparsification for the GDC transform#6245
Open
marekdedic wants to merge 4 commits intopyg-team:masterfrom
Open
Implemented sparse variant of top-k sparsification for the GDC transform#6245marekdedic wants to merge 4 commits intopyg-team:masterfrom
marekdedic wants to merge 4 commits intopyg-team:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6245 +/- ##
==========================================
+ Coverage 91.27% 91.29% +0.01%
==========================================
Files 436 436
Lines 23894 23912 +18
==========================================
+ Hits 21810 21830 +20
+ Misses 2084 2082 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rusty1s
reviewed
Jan 3, 2023
Member
rusty1s
left a comment
rusty1s
left a comment
There was a problem hiding this comment.
Thanks for the PR. Can we add a small test for this as well?
Contributor
Author
|
Thanks, I'll try to add one. |
marekdedic
force-pushed
the
gdc-sparse-topk-sparsification
branch
from
94bee0d to
951dc31
Compare
marekdedic
requested review from
akihironitta,
mananshah99 and
wsad1
as code owners
marekdedic
force-pushed
the
gdc-sparse-topk-sparsification
branch
from
951dc31 to
c3f0c89
Compare
marekdedic
force-pushed
the
gdc-sparse-topk-sparsification
branch
from
c3f0c89 to
0704bbf
Compare
marekdedic
force-pushed
the
gdc-sparse-topk-sparsification
branch
from
0704bbf to
a307f06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
the GDC transform was missing a sparse variant of the top-k sparsification method, so I share my implementation... Feedback welcome.