Fix LPFormer attention dimensions#10680
Open
BWAAEEEK wants to merge 2 commits intopyg-team:masterfrom
Open
Conversation
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes LPFormer attention layer sizes for multi-layer and multi-head deployments.
The initial implementation makes reference to an undefined
self.num_layerswhile constructing transformer layers. All of these changes fixed that, but multi-layer configurations still ended up producing mismatched pairwise feature dimensions because the final attention layer output consistently had2 * hidden_channels size.Also, multi-head attention output normalisation used
out_channelsinstead ofnum_heads * out_channels.Change Summary
This PR modifies the construction of LPFormer layers to use dimensions on edge feature input/output., and adds regression coverage for
num_transformer_layers in {1, 2}, andnum_heads in {1, 2}.Tested with: