Add minimal [segment|grouped]_matmul CPU implementation#111
Merged
Conversation
6122700 to
63db468
Compare
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 89.23% 94.33% +5.10%
==========================================
Files 16 19 +3
Lines 418 477 +59
==========================================
+ Hits 373 450 +77
+ Misses 45 27 -18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
Author
|
@rusty1s It seems that docs build is failing because of: The installed version is now |
Member
|
Yes, will look into. |
Member
|
Seems like |
a1f7eda to
7cadd0a
Compare
7cadd0a to
a642ab8
Compare
Member
Author
|
@rusty1s Please take a look. 😉 |
rusty1s
approved these changes
Oct 3, 2022
Member
rusty1s
left a comment
There was a problem hiding this comment.
Thanks for this PR and the dispatcher fix. I really had no idea how one could resolve it :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added minimal
[segment|grouped]_matmulCPU implementation, usingat::matmul_out.Next steps (other PR):
Optimize code using
gemm_batched(preview).Update:
An additional fix was provided for
grouped_matmulwhich occurred on both CPU and GPU.It was caused by the wrong
grouped_matmulfunction signature - it was not aligned with the schema provided atTORCH_LIBRARY_FRAGMENTcall. As stated here,Tensor[]as input is equivalent ofat::TensorList.