AttributError in fields.py for Function

[Barneby77]

Hi Deid - Team!

When updating from deid 0.4.6 to 0.4.7 I get this error in the log:

 python3.11/site-packages/deid/dicom/fields.py", line 376, in _get_field_lookup_keys case_insensitive_field = field.lower()
AttributeError : 
'function' object has no attribute 'lower'

For debugging I added the line with the prints to the code of _get_field_lookup_keys:

    def _get_field_lookup_keys(self, field):
        if not isinstance(field, DicomField):
            print(field, type(field))
            case_insensitive_field = field.lower()

With the next run I get this right before the traceback:

<function shiftDate at 0x7f1ed292bb00>
<class 'function'>

shiftDate is a function that I created and use in the recipe as follows:

REPLACE StudyDate func:shiftDate

Are functions no longer supported?

[vsoch]

@Barneby77 functions should work. This was likely a bug introduced somewhere around #289. Could you try the latest version of pypi, and if the bug is still there, I'll ping the contributor?

[Barneby77]

I tested the package upgrade in a new venv. So everything should be up to date. Just checked again:

pip == 25.3
pydicom == 3.0.1

Seems the lower() works for strings, but not for the passed function.