Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #8702 / #8702 (comment)
The goal is to remove the not elegant OS-dependant checks introduced during the testing of #8702
A simple way to do so is to use unsigned integer as dtypes for tests involving data array representations on multiple OSes. Indeed, this solves the issue of the default dtypes being not printed in the repr, with default dtyps varying according to the OS. The tests show that the concerned dtypes are
int32(for the Windows CI) andint64(for Ubuntu and macOS CIs). Usinguint64should fix both the varying size and the varying numpy array repr.- [ ] Closes #xxxx- [ ] User visible changes (including notable bug fixes) are documented inwhats-new.rst- [ ] New functions/methods are listed inapi.rst