Skip to content

ndrolling repr fix #4329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keewis merged 4 commits into from
Aug 9, 2020
Merged

ndrolling repr fix #4329

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
65381f3
ndrolling repr fix
fujiisoup Aug 8, 2020
7e1fbf8
better tests
fujiisoup Aug 8, 2020
61c9ff9
correct doc and error message.
fujiisoup Aug 9, 2020
3b9cf98
also update the mean dimensions.
fujiisoup Aug 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xarray/core/rolling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ def __repr__(self):
"""provide a nice str repr of our rolling object"""

attrs = [
"{k}->{v}".format(k=k, v=getattr(self, k))
for k in list(self.dim) + self.window + self.center + [self.min_periods]
"{k}->{v}{c}".format(k=k, v=w, c="(center)" if c else "")
for k, w, c in zip(self.dim, self.window, self.center)
]
return "{klass} [{attrs}]".format(
klass=self.__class__.__name__, attrs=",".join(attrs)
Expand Down
2 changes: 2 additions & 0 deletions xarray/tests/test_dataarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6178,6 +6178,8 @@ def test_rolling_iter(da):
actual.values[actual.values.nonzero()],
expected.values[expected.values.nonzero()],
)
# no error
repr(rolling_obj)


def test_rolling_doc(da):
Expand Down