Skip to content

Allow binned coordinates on 1D plots y-axis. #3685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcherian merged 7 commits into from
Jan 22, 2020
Merged

Allow binned coordinates on 1D plots y-axis. #3685

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b8f082b
Allow binned coords on 1D plots y-axis. See #3571.
juseg Jan 11, 2020
6bb20a2
Add helper to convert intervals for 1d plots.
juseg Jan 14, 2020
c2c4134
Add tests for line plots with x/y/x&y intervals.
juseg Jan 20, 2020
d91acfc
Add tests for step plots with x/y intervals.
juseg Jan 20, 2020
10e3017
Simplify syntax in 1D intervals plot helper.
juseg Jan 20, 2020
ca7a0a6
Merge branch master into plot_ybins.
juseg Jan 22, 2020
b182e0b
Document new handling of y-axis intervals.
juseg Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions xarray/plot/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,12 @@ def line(
xplt, yplt, hueplt, xlabel, ylabel, hue_label = _infer_line_data(darray, x, y, hue)

# Remove pd.Intervals if contained in xplt.values.
if _valid_other_type(xplt.values, [pd.Interval]):
if any(
[
_valid_other_type(xplt.values, [pd.Interval]),
_valid_other_type(yplt.values, [pd.Interval]),
]
):
# Is it a step plot? (see matplotlib.Axes.step)
if kwargs.get("linestyle", "").startswith("steps-"):
xplt_val, yplt_val = _interval_to_double_bound_points(
Expand All @@ -313,8 +318,14 @@ def line(
if kwargs["linestyle"] == "":
del kwargs["linestyle"]
else:
xplt_val = _interval_to_mid_points(xplt.values)
yplt_val = yplt.values
if _valid_other_type(xplt.values, [pd.Interval]):
xplt_val = _interval_to_mid_points(xplt.values)
else:
xplt_val = xplt.values
if _valid_other_type(yplt.values, [pd.Interval]):
yplt_val = _interval_to_mid_points(yplt.values)
else:
yplt_val = yplt.values
xlabel += "_center"
else:
xplt_val = xplt.values
Expand Down