Avoid a clone and add some more comments #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jun 25, 2025
| buffer: ValueBuffer, | ||
| pending: Option<(String, usize)>, | ||
| /// Is there a pending list or object that needs to be finalized? | ||
| pending: Option<(&'b str, usize)>, |
Author
There was a problem hiding this comment.
I started this PR to see if I could avoid this owned string, which it turns out you can
alamb
commented
Jun 25, 2025
| Variant::ShortString(s) => self.append_short_string(s), | ||
| Variant::Object(_) | Variant::List(_) => { | ||
| todo!("How does this work with the redesign?"); | ||
| unreachable!("Nested values are handled specially by ObjectBuilder and ListBuilder"); |
Author
There was a problem hiding this comment.
I noticed this too and figured it was related and I would update the comment
friendlymatthew
merged commit 2fb3d42
into
pydantic:friendlymatthew/nested-object-building
10 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing https://github.com/apache/arrow-rs/pull/7778/files I wanted some additional comments and also to avoid a String clone. I will comment inline