Avoid std::type_info pointer comparison #914
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type equality needs to be done with `operator==` on the `std::type_info` object; we do this in some places, but in a few places use pointer equality (i.e. the equivalent of &typeid(A) == &typeid(B)). This replaces all such cases with std::type_info equality comparisons.
This was referenced Jun 21, 2017
Member
Author
|
Closed in favour of #915. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type equality needs to be done with
operator==on thestd::type_infoobject; we do this in some places, but in a few placesuse pointer equality (i.e. the equivalent of &typeid(A) == &typeid(B)).
This replaces all such cases with std::type_info equality comparisons.
I noticed this in investigation of #912, but it does not fix that issue.