Skip to content

Explicitly define move constructor for accessor #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jagerman merged 3 commits into from
Jun 6, 2017
Merged

Explicitly define move constructor for accessor #888

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59669a8
Explicitly define move constructor for accessor
eirrgang Jun 5, 2017
7d9dbb0
Update pytypes.h
eirrgang Jun 6, 2017
29a6cdb
Update pytypes.h
eirrgang Jun 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/pybind11/pytypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@ class accessor : public object_api<accessor<Policy>> {
// to replace default compiler-generated assignments).
void operator=(const accessor &a) && { std::move(*this).operator=(handle(a)); }
void operator=(const accessor &a) & { operator=(handle(a)); }
accessor(accessor &a) = default;

@jagerman jagerman Jun 6, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing const

@eirrgang eirrgang Jun 6, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops. Thanks.

accessor(accessor &&a) = default;

template <typename T> void operator=(T &&value) && {
Expand Down