bugfix: allow noexcept lambdas in C++17. Fix #4565#4593
Merged
Skylion007 merged 4 commits intoMar 28, 2023
Conversation
Skylion007
force-pushed
the
skylion007/allow-noexcept-lambdas
branch
from
March 27, 2023 16:54
350f472 to
bc62536
Compare
Skylion007
marked this pull request as ready for review
March 27, 2023 17:39
Skylion007
changed the title
rwgk
approved these changes
Mar 27, 2023
rwgk
left a comment
rwgk
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for taking care of this!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows lambda specified to function defs to be
noexcept(true)in C++17. This ended up being a rather quick fix compared to more general case which would require some extensive meta-templating to do this properly in C++17.Suggested changelog entry: