fix(cmake): support Windows ARM cross-compilation#4406
Merged
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii-patch-3
branch
from
December 15, 2022 03:24
9e27c7c to
90a87ff
Compare
henryiii
marked this pull request as ready for review
December 15, 2022 18:29
Collaborator
Author
|
Just shipped Windows ARM cross-compile support in scikit-build-core 0.1.4 and scikit-build 0.16.4. This patch would be great to get in for projects using pybind11, like pybind/scikit_build_example#65. |
Skylion007
approved these changes
Dec 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, even if you manually set the libraries variable to an ARM library, this still gets the Intel library when cross-compiling on Windows.
Suggested changelog entry: