Skip to content

chore: Convert direct multiprocessing.set_start_method("forkserver") call to a pytest fixture. #4377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Skylion007 merged 2 commits into from
Dec 1, 2022
Merged

chore: Convert direct multiprocessing.set_start_method("forkserver") call to a pytest fixture. #4377

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c7afbc
chore: convert multiprocessing set_spawn to fixture in pytest
Skylion007 Dec 1, 2022
9b9d040
Switch to early return
Skylion007 Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,12 @@
# Early diagnostic for failed imports
import pybind11_tests

if os.name != "nt":

@pytest.fixture(scope="session", autouse=True)
def always_forkserver_on_unix():
if os.name == "nt":
return

# Full background: https://github.com/pybind/pybind11/issues/4105#issuecomment-1301004592
# In a nutshell: fork() after starting threads == flakiness in the form of deadlocks.
# It is actually a well-known pitfall, unfortunately without guard rails.
Expand All @@ -27,6 +32,7 @@
# running with defaults.
multiprocessing.set_start_method("forkserver")


_long_marker = re.compile(r"([0-9])L")
_hexadecimal = re.compile(r"0x[0-9a-fA-F]+")

Expand Down