Skip to content

Conversation

@Skylion007
Copy link
Collaborator

Description

Fix oversight in #4302

@Skylion007 Skylion007 requested a review from henryiii as a code owner November 1, 2022 14:57
@henryiii
Copy link
Collaborator

henryiii commented Nov 1, 2022

CMake 3.23.5 was just released and the binary artifacts haven't built and uploaded yet. Perfectly bad timing. :) (Though we probably should bump to 3.24.x)

@Skylion007
Copy link
Collaborator Author

Merging this anyway since the pre-commit hook update is fine though.

@Skylion007 Skylion007 merged commit 0176632 into pybind:master Nov 1, 2022
@Skylion007 Skylion007 deleted the fix-precommit-blacken-hook branch November 1, 2022 16:19
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Nov 1, 2022
rwgk pushed a commit that referenced this pull request Nov 18, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants