Skip to content

Conversation

@henryiii
Copy link
Collaborator

@henryiii henryiii commented Oct 8, 2022

Reverts #4220

@rwgk
Copy link
Collaborator

rwgk commented Oct 8, 2022

Trying a forward fix: e9070b2

At this second tested only interactively.

Needs to pass #4228 (master)

Needs to pass #4227 (smart_holder)

@rwgk
Copy link
Collaborator

rwgk commented Oct 8, 2022

The commit mentioned in the previous comment had a flaw due to a misunderstanding, fixed in 7557684. Retesting.

@rwgk
Copy link
Collaborator

rwgk commented Oct 8, 2022

It is pretty much certain now that the forward fix in #4228 is working. The CI for that PR passes, I just need to reduce my new test before sending it for review.

The forward fix also works for the smart_holder branch (#4227), although something else is still failing for CUDA 11.7 (type_caster_odr_guard), but that is not critical, I just need to add some kind of suppression for this non-cooperating compiler (the only thing I truly care about is that the type_caster_odr_guard works Google-internally).

@henryiii
Copy link
Collaborator Author

henryiii commented Oct 8, 2022

Okay, will go with that one, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants