fix: better exception and error handling for capsules#3825
Merged
Skylion007 merged 2 commits intoMar 25, 2022
Conversation
rwgk
approved these changes
Mar 24, 2022
rwgk
left a comment
Collaborator
There was a problem hiding this comment.
Thanks a lot for this cleanup, the revised code makes a lot more sense!
I'll try to run this through our global testing tonight, but if you need this before I have the results, please go ahead.
Collaborator
standing? standard? Maybe: ? |
Collaborator
|
The test ID for the global testing is |
Collaborator
|
The global testing finished without finding any issues. |
Collaborator
Author
|
@rwgk Fixed spelling errors in the PR description. |
henryiii
approved these changes
Mar 25, 2022
henryiii
left a comment
Collaborator
There was a problem hiding this comment.
Looks fantastic to me. :)
henryiii
pushed a commit
to henryiii/pybind11
that referenced
this pull request
Mar 25, 2022
* Make capsule errors better match python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Suggested changelog entry: