Skip to content

[smart_holder] Companion to @iwanders PR #3590 #3601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwgk wants to merge 4 commits into from
Closed

[smart_holder] Companion to @iwanders PR #3590 #3601

rwgk wants to merge 4 commits into from

Conversation

@rwgk
Copy link
Collaborator

@rwgk rwgk commented Jan 7, 2022 •
edited
Loading

Description

WIP

This PR will only be merged after PR #3590 was merged into master. At that point the net diff will simply be 41a549c.

Suggested changelog entry:



    

  
  



      


          

          
  
  

    
  
    
    

  

  

  



          

        
      




  




      

       
            



      

  
        





      

  
            

    

      
    

    


      


          @rwgk
rwgk




        changed the title
Sh using iwanders cmake

[smart_holder] Companion to @iwanders PR #3590


      Jan 7, 2022

    

  



  

  

    
  


  

      


  This was referenced Jan 7, 2022





  


  

      
     Closed

  






      







  


  

      
     Merged

  






  









      

  
        





      

  
          

  

    
  


  

      


    @rwgk
rwgk



    mentioned this pull request
    
      Jan 8, 2022
    





  


  

      
     Closed

  







  









      

  
      



  

  @rwgk






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

        
      

    


    

        

  
    Collaborator


        

  Author


    

  


  

    

      
          
      

      
            rwgk
  

      

      

      commented


        Jan 12, 2022


      
    


  





      


        



  
    

      
          
This was just merged via cherry-pick to sh_merge_master, then git pull . from there to smart_holder, then git push.


Thanks again @iwanders!



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
            

    

      
    

    


      


          @rwgk
rwgk




            closed this


      Jan 12, 2022

    

  


    


  

  
  

  
      @rwgk
  rwgk


    
    deleted the
    
      
        sh_using_iwanders_cmake
    
    branch

    January 12, 2022 17:01    
    




  

  

    
  


  

      


    @rwgk
rwgk



    mentioned this pull request
    
      Feb 10, 2023
    





  


  

      

  
  Closed

  







  













  
  

    

      

  




      


    


    

      

        
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          



      

  

    
    

    

  

    Reviewers
  


    

    No reviews






    
    

    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
      

  

    

      2 participants
    

    

        
          @rwgk 
        
          @iwanders