Skip to content

Fix thread safety for pybind11 loader_life_support #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Skylion007 merged 28 commits into from
Sep 10, 2021
Merged

Fix thread safety for pybind11 loader_life_support #3237

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
53b3919
Fix thread safety for pybind11 loader_life_support
laramiel Sep 2, 2021
caa974f
Also update the internals version as the internal struct is no longer…
laramiel Sep 2, 2021
9179d60
Add test demonstrating threading works correctly.
laramiel Sep 3, 2021
0c2bf55
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 3, 2021
4b7dc7a
Update test to use lifetime-extended references rather than
laramiel Sep 3, 2021
fdfff88
Merge branch 'master' of https://github.com/laramiel/pybind11
laramiel Sep 3, 2021
d91a4a7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 3, 2021
c6720ca
Make loader_life_support members private
laramiel Sep 3, 2021
2c07c0d
Merge branch 'master' of https://github.com/laramiel/pybind11
laramiel Sep 3, 2021
8a1a59f
Update version to dev2
laramiel Sep 3, 2021
dfc94f3
Update test to use python threading rather than concurrent.futures
laramiel Sep 3, 2021
4f25e31
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 3, 2021
366f40d
Remove unnecessary env in test
laramiel Sep 3, 2021
b5a0538
Remove unnecessary pytest in test
laramiel Sep 3, 2021
ffc52a3
Use native C++ thread_local in place of python per-thread data struct…
laramiel Sep 3, 2021
dc7df66
clang-format test_thread.cpp
laramiel Sep 3, 2021
dd8f264
Add a note about debugging the py::cast() error
laramiel Sep 3, 2021
c4c6acb
thread_test.py now propagates exceptions on join() calls.
laramiel Sep 7, 2021
6ad3de6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 7, 2021
d7e3067
remove unused sys / merge
laramiel Sep 7, 2021
638d091
Update include order in test_thread.cpp
laramiel Sep 9, 2021
a06f851
Remove spurious whitespace
laramiel Sep 9, 2021
5c58953
Update comment / whitespace.
laramiel Sep 9, 2021
5f66855
Address review comments
laramiel Sep 9, 2021
1237bbe
lint cleanup
laramiel Sep 9, 2021
afbc066
Fix test IntStruct constructor.
laramiel Sep 9, 2021
fe49b37
Merge branch 'master' of https://github.com/pybind/pybind11
Skylion007 Sep 10, 2021
5787104
Add explicit to constructor
Skylion007 Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/test_thread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import pytest

import env # noqa: F401
from pybind11_tests import thread as m


Expand Down