Skip to content

test_eval: Show example of working closure #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Skylion007 merged 3 commits into from
Aug 6, 2021
Merged

test_eval: Show example of working closure #2743

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27519dd
test_eval: Show example of working closure
EricCousineau-TRI Dec 24, 2020
649a1e7
Extend test_eval_closure with weirder examples of closures for py::eval
YannickJadoul Jan 25, 2021
c29ebce
Merge branch 'master' of https://github.com/pybind/pybind11 into feat…
Skylion007 Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/test_eval.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ TEST_SUBMODULE(eval_, m) {
// test_evals

auto global = py::dict(py::module_::import("__main__").attr("__dict__"));
py::handle copy = py::module::import("copy").attr("copy");

m.def("test_eval_statements", [global]() {
auto local = py::dict();
Expand Down Expand Up @@ -96,4 +97,15 @@ TEST_SUBMODULE(eval_, m) {
auto int_class = py::eval("isinstance(42, int)", global);
return global;
});

m.def("test_eval_closure", [global, copy]() {
Copy link
Collaborator

@YannickJadoul YannickJadoul Dec 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add the // test_eval_closure comment above. In this case, it's a bit over the top since your function is already called that, but I like the existing convention of indicating the Python-side tests that C++-side bindings belong to.

py::dict local = copy(global);
py::exec(R"(
closure_value = 10

def func():
return closure_value
)", local, local);
Copy link
Collaborator

@YannickJadoul YannickJadoul Dec 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is local being passed twice here? And from reading #1742, shouldn't this be called global as it's the globals dict?

return local;
});
}
5 changes: 5 additions & 0 deletions tests/test_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,8 @@ def test_eval_empty_globals():
g = {}
assert "__builtins__" in m.eval_empty_globals(g)
assert "__builtins__" in g


def test_eval_closure():
local = m.test_eval_closure()
assert local["func"]() == 10