Allow ostream-redirection of more than 1024 characters#1479
Merged
Conversation
Contributor
Author
|
The CI errors seem to be a warning about using a deprecated numpy type ( |
Member
|
There is something I don't understand about the original implementation, which is somewhat related to the patch here. It looks like |
Contributor
Author
|
If someone wrote a class which inherits from |
Member
|
Ah, gotcha -- it's a virtual function in the C++ standard. This looks good to me then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1478
In short,
detail::pythonbuf::overflow()had its branch for the return statement backwards, sincebool(sync())istrueif and only ifsync()fails;sync()returns0on success. This fixes it by usingsync() == 0as the condition.