Ci build updates#1155
Merged
Merged
Conversation
Building with the (VS2017) /permissive- flag puts the compiler into stricter standards-compliant mode. It shouldn't cause the compiler to work differently--it just disallows some non-conforming code--so should be perfectly fine for the test suite under all VS2017 builds. This commit also fixes one failure under non-permissive mode.
- For the debian/buster docker build (GCC 7/C++17) install and use the
system `catch` package; this also renames "COMPILER_PACKAGES" to
"EXTRA_PACKAGES" since it now contains a non-compiler package.
- Add a status message indicating the catch version being used for
compiling the embedded tests
- Simplify some bash code by using VAR+=" foo" to append (rather than
VAR="${VAR} foo"
- Fix CMAKE_INCLUDE_PATH appending: it was prepending the ':' but not
the existing $CMAKE_INCLUDE_PATH value and so would end up with
":/eigen-path" if CMAKE_INCLUDE_PATH was already set. (This wasn't
bug that was actually noticed since currently nothing else sets it).
This was referenced Oct 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some miscellaneous ci updates:
appveyor: build with /permissive- under MSVC 2017 to force stricter standards mode. This hits one issue (Compile failure with MSVC and /permissive- (Two-phase lookup) #1107), which is also fixed as part of this commit (i.e. it incorporates Add .template keyword to fix VS2017 /permissive- compilation #1154). Fixes Compile failure with MSVC and /permissive- (Two-phase lookup) #1107.
use system
catchpackage for gcc 7/c++17 build (where the current version indebian:busterhas recently been updated; the one indebian:stretchused by the other docker builds is much too old).minor simplification to the bash scripts to use
FOO+=" ..."rather thanFOO="${FOO} ..."one other minor fix to the
CMAKE_INCLUDE_PATHoverride for Eigen; the current code prepended a:but was missing the current variable contents. (This doesn't currently cause any problems because nothing else sets the include path; I just happened to notice it while making the other changes here).