Enable stratification in bootstrap #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbattocchi
force-pushed
the
kebatt/bootstrapFixes
branch
2 times, most recently
from
7b8054c to
aeb6948
Compare
kbattocchi
force-pushed
the
kebatt/bootstrapFixes
branch
3 times, most recently
from
94a4cea to
715adbe
Compare
kbattocchi
force-pushed
the
kebatt/bootstrapFixes
branch
from
6c7caba to
600a403
Compare
kbattocchi
force-pushed
the
kebatt/bootstrapFixes
branch
from
600a403 to
c561cd6
Compare
kbattocchi
force-pushed
the
kebatt/bootstrapFixes
branch
2 times, most recently
from
b788c13 to
50c5613
Compare
kbattocchi
force-pushed
the
kebatt/bootstrapFixes
branch
6 times, most recently
from
c0529c4 to
52eff24
Compare
Collaborator
|
The point estimate in the bootstrap should be the estimate on the original set of samples, not the mean of the bootstrap subsamples. |
vsyrgkanis
requested changes
Sep 8, 2020
vsyrgkanis
requested changes
Sep 8, 2020
vsyrgkanis
requested changes
Sep 8, 2020
vsyrgkanis
requested changes
Sep 8, 2020
vsyrgkanis
requested changes
Sep 8, 2020
vsyrgkanis
requested changes
Sep 8, 2020
moprescu
approved these changes
Sep 11, 2020
kbattocchi
force-pushed
the
kebatt/bootstrapFixes
branch
from
0490101 to
63daf39
Compare
kbattocchi
requested review from
vsyrgkanis
and removed request for
vasilismsr
vsyrgkanis
approved these changes
Oct 23, 2020
Collaborator
vsyrgkanis
left a comment
vsyrgkanis
left a comment
There was a problem hiding this comment.
Small change in marginal_effect_inference logic at the LinearCateEstimator level is required.
kbattocchi
force-pushed
the
kebatt/bootstrapFixes
branch
2 times, most recently
from
c0e95f7 to
8084c0a
Compare
vsyrgkanis
reviewed
Oct 30, 2020
Collaborator
vsyrgkanis
left a comment
vsyrgkanis
left a comment
There was a problem hiding this comment.
Are these really the only places where const_marginal_effect_interval and inference are defined, or are there many other places where the signature needs to change??
kbattocchi
force-pushed
the
kebatt/bootstrapFixes
branch
from
8084c0a to
11c9dac
Compare
kbattocchi
force-pushed
the
kebatt/bootstrapFixes
branch
from
11c9dac to
f4f0bf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125. Fixes #89.