Skip to content

BUG: Fix missing "PreventGC" when cloning #3520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefan6419846 merged 5 commits into from
Nov 14, 2025
Merged

BUG: Fix missing "PreventGC" when cloning #3520

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b588e8
Fix missing "PreventGC" when cloning
patrick91 Nov 13, 2025
8f3a323
Type ignore
patrick91 Nov 13, 2025
905f91e
Better type ignore
patrick91 Nov 14, 2025
13e0011
test: add regression test for garbage collection bug
bellini666 Nov 14, 2025
5f590cf
fix import ordering
bellini666 Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pypdf/generic/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@ def clone(
return self
if id(self.pdf) not in pdf_dest._id_translated:
pdf_dest._id_translated[id(self.pdf)] = {}
pdf_dest._id_translated[id(self.pdf)]["PreventGC"] = self.pdf # type: ignore

if self.idnum in pdf_dest._id_translated[id(self.pdf)]:
dup = pdf_dest.get_object(pdf_dest._id_translated[id(self.pdf)][self.idnum])
Expand Down
Loading