DEV: Use Mapping instead of dict in type hint of update_page_form_field values #3490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld_values Having the parameter typed as a dictionary does not allow for stricter type hints on the user side, like `dict[str, str]`, as a dictionary is considered mutable. Typing our method as `Mapping` indicates that we do not change the corresponding values inside it and does allow for stricter typing in user code. Closes py-pdf#3453.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stefan6419846
added a commit
that referenced
this pull request
Oct 19, 2025
## What's new ### Bug Fixes (BUG) - Fix handling of zero-length StreamObject (#3485) by @Likend ### Robustness (ROB) - Deal with wrong size for incremental PDF files (#3495) by @stefan6419846 - Improve handling for malformed cross-reference tables (#3483) by @stefan6419846 ### Developer Experience (DEV) - Use released Python 3.14 by @stefan6419846 - Use Mapping instead of dict in type hint of update_page_form_field_values (#3490) by @stefan6419846 [Full Changelog](6.1.1...6.1.2)
OpenNingia
pushed a commit
to OpenNingia/pypdf
that referenced
this pull request
Oct 23, 2025
…ld_values (py-pdf#3490) Having the parameter typed as a dictionary does not allow for stricter type hints on the user side, like `dict[str, str]`, as a dictionary is considered mutable. Typing our method as `Mapping` indicates that we do not change the corresponding values inside it and does allow for stricter typing in user code. Closes py-pdf#3453.
OpenNingia
pushed a commit
to OpenNingia/pypdf
that referenced
this pull request
Oct 23, 2025
## What's new ### Bug Fixes (BUG) - Fix handling of zero-length StreamObject (py-pdf#3485) by @Likend ### Robustness (ROB) - Deal with wrong size for incremental PDF files (py-pdf#3495) by @stefan6419846 - Improve handling for malformed cross-reference tables (py-pdf#3483) by @stefan6419846 ### Developer Experience (DEV) - Use released Python 3.14 by @stefan6419846 - Use Mapping instead of dict in type hint of update_page_form_field_values (py-pdf#3490) by @stefan6419846 [Full Changelog](py-pdf/pypdf@6.1.1...6.1.2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the parameter typed as a dictionary does not allow for stricter type hints on the user side, like
dict[str, str], as a dictionary is considered mutable. Typing our method asMappingindicates that we do not change the corresponding values inside it and does allow for stricter typing in user code.Closes #3453.