Skip to content

MAINT: Remove some deprecation_no_replacement #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-t-1 wants to merge 4 commits into from
Closed

MAINT: Remove some deprecation_no_replacement #3433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d3336a
MAINT: Remove some deprecation_no_replacement
j-t-1 Aug 13, 2025
020787b
Fix imported but unused
j-t-1 Aug 13, 2025
ae75202
Fix incompatible signature with supertype
j-t-1 Aug 13, 2025
62d9a1a
Fix imported but unused
j-t-1 Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 5 additions & 22 deletions pypdf/generic/_data_structures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
from .._utils import (
WHITESPACES,
StreamType,
deprecation_no_replacement,
logger_warning,
read_non_whitespace,
read_until_regex,
Expand Down Expand Up @@ -217,12 +216,8 @@ def __isub__(self, lst: Any) -> Self:
return self

def write_to_stream(
self, stream: StreamType, encryption_key: Union[None, str, bytes] = None
self, stream: StreamType
) -> None:
if encryption_key is not None: # deprecated
deprecation_no_replacement(
"the encryption_key parameter of write_to_stream", "5.0.0"
)
stream.write(b"[")
for data in self:
stream.write(b" ")
Expand Down Expand Up @@ -494,17 +489,13 @@ def xmp_metadata(self) -> Optional[XmpInformationProtocol]:
return XmpInformation(metadata)

def write_to_stream(
self, stream: StreamType, encryption_key: Union[None, str, bytes] = None
self, stream: StreamType
) -> None:
if encryption_key is not None: # deprecated
deprecation_no_replacement(
"the encryption_key parameter of write_to_stream", "5.0.0"
)
stream.write(b"<<\n")
for key, value in self.items():
if len(key) > 2 and key[1] == "%" and key[-1] == "%":
continue
key.write_to_stream(stream, encryption_key)
key.write_to_stream(stream)
stream.write(b" ")
value.write_to_stream(stream)
stream.write(b"\n")
Expand Down Expand Up @@ -984,12 +975,8 @@ def hash_value_data(self) -> bytes:
return data

def write_to_stream(
self, stream: StreamType, encryption_key: Union[None, str, bytes] = None
self, stream: StreamType
) -> None:
if encryption_key is not None: # deprecated
deprecation_no_replacement(
"the encryption_key parameter of write_to_stream", "5.0.0"
)
self[NameObject(SA.LENGTH)] = NumberObject(len(self._data))
DictionaryObject.write_to_stream(self, stream)
del self[SA.LENGTH]
Expand Down Expand Up @@ -1663,12 +1650,8 @@ def dest_array(self) -> "ArrayObject":
)

def write_to_stream(
self, stream: StreamType, encryption_key: Union[None, str, bytes] = None
self, stream: StreamType
) -> None:
if encryption_key is not None: # deprecated
deprecation_no_replacement(
"the encryption_key parameter of write_to_stream", "5.0.0"
)
stream.write(b"<<\n")
key = NameObject("/D")
key.write_to_stream(stream)
Expand Down
10 changes: 2 additions & 8 deletions pypdf/generic/_outline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
from typing import Union

from .._utils import StreamType, deprecation_no_replacement
from .._utils import StreamType
from ._base import NameObject
from ._data_structures import Destination


class OutlineItem(Destination):
def write_to_stream(
self, stream: StreamType, encryption_key: Union[None, str, bytes] = None
self, stream: StreamType
) -> None:
if encryption_key is not None: # deprecated
deprecation_no_replacement(
"the encryption_key parameter of write_to_stream", "5.0.0"
)
stream.write(b"<<\n")
for key in [
NameObject(x)
Expand Down
Loading