Skip to content

Show compiled JS based on query params only #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2022
Merged

Show compiled JS based on query params only #296

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5052d23
Show compiled JS based on query params only
JordanMartinez Aug 12, 2022
45ad505
Add changelog entry
JordanMartinez Aug 12, 2022
a3a3b24
Merge branch 'master' into jam/view-code-via-link
JordanMartinez Aug 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Breaking changes:
New features:

Bugfixes:
- Stop loading hang when using query params to show compiled JS output (#296 by @JordanMartinez)

Other improvements:

Expand Down
3 changes: 2 additions & 1 deletion client/src/Try/Container.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,9 @@ component = H.mkComponent

Right res@(Right (CompileSuccess { js, warnings })) -> do
{ settings } <- H.get
if settings.showJs then
if settings.showJs then do
H.liftEffect teardownIFrame
H.modify_ _ { compiled = Just res }
else do
for_ warnings \warnings_ -> do
let anns = Array.mapMaybe (toAnnotation MarkerWarning) warnings_
Expand Down