Skip to content

Add toRep #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 26, 2020
Merged

Add toRep #238

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8163e62
Add toRep
JordanMartinez Dec 25, 2020
28b00be
Update type variable names to match class names
JordanMartinez Dec 25, 2020
3da6cdb
Rename toRep to repOf
JordanMartinez Dec 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Data/Generic/Rep.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ module Data.Generic.Rep
( class Generic
, to
, from
, toRep
, NoConstructors
, NoArguments(..)
, Sum(..)
Expand All @@ -10,6 +11,8 @@ module Data.Generic.Rep
, Argument(..)
) where

import Type.Proxy (Proxy(..))

-- | A representation for types with no constructors.
data NoConstructors

Expand All @@ -34,3 +37,6 @@ newtype Argument a = Argument a
class Generic a rep | a -> rep where
to :: rep -> a
from :: a -> rep

toRep :: forall from to. Generic from to => Proxy from -> Proxy to
Copy link
Member

@kl0tl kl0tl Dec 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we reuse a and rep variables, like in the class declaration?

Copy link
Contributor Author

@JordanMartinez JordanMartinez Dec 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Member

@kl0tl kl0tl Dec 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I don’t know about you but I frequently confuse to and from, and I’m sure having to :: rep -> a but toRep :: Proxy a -> Proxy rep is going to be even more confusing to me 😬 May I suggest repOf instead?

Copy link
Contributor Author

@JordanMartinez JordanMartinez Dec 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

toRep _ = Proxy