Delete dubious double-download #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't imagine the purpose of this code that starts, and then cancels, a second download in parallel with the first. After recent changes to the internals of dl-tar, the cancellation was no longer effective, and the two download-and-extract processes ended up interfering with each other sometimes. Removing this code seems strictly beneficial; maybe one day I'll regret this but right now I can't see a reason to keep it.
JordanMartinez
approved these changes
Dec 3, 2022
garyb
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't imagine the purpose of this code that starts, and then cancels, a second download in parallel with the first. After recent changes to the internals of dl-tar, the cancellation was no longer effective, and the two download-and-extract processes ended up interfering with each other sometimes.
Removing this code seems strictly beneficial; maybe one day I'll regret this but right now I can't see a reason to keep it.
Fixes #37.