(GH-188) Filter current environment variables #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Protected Event Logging and PowerShell Script Block logging are enabled together the SystemRoot environment variable is a requirement. If it is removed as part of the environment purge it causes the PowerShell process to crash, therefore breaking the pipe between Ruby and the remote PowerShell session. This commit fixes the issue by creating a filtered list of environment variables which does not include the SystemRoot environment variable. This list can then be purged safely.
chelnak
force-pushed
the
GH-188-fix_environment_reset
branch
from
7a43e6f to
10a9081
Compare
LukasAud
approved these changes
Jun 24, 2022
david22swan
approved these changes
Jun 24, 2022
Member
david22swan
left a comment
david22swan
left a comment
There was a problem hiding this comment.
LGTM
Though my powershell is not perfect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Protected Event Logging and PowerShell Script Block logging are enabled together the SystemRoot environment variable is a requirement.
If it is removed as part of the environment purge it causes the PowerShell process to crash, therefore breaking the pipe between Ruby and the remote PowerShell session.
This PR fixes the issue by creating a filtered list of environment variables which does not include the SystemRoot environment variable.
This list can then be purged safely.
Closes #188