backports: don't hardcode an old gpg key for Ubuntu #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
requested review from
a team,
bastelfreak and
smortex
as code owners
kenyon
force-pushed
the
ubuntu-backport-gpg-key
branch
from
445e5f2 to
f768a62
Compare
Author
|
Not sure why that Ubuntu 18.04 test is failing, but it started failing in #1124, and seems unrelated to this module's code. |
smortex
approved these changes
Sep 18, 2023
Collaborator
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
This look fine. CI failure looks unrelated.
The default key for Debian was removed in puppetlabs#847, and I'm about to do the same for Ubuntu.
Same as puppetlabs#847 but for Ubuntu. The gpg keys used to sign the Ubuntu repos, including backports, come with standard Ubuntu installations, so this Puppet module doesn't need to add any key. Having this old key causes Puppet run failures for 20.04 and newer machines without Internet access.
kenyon
force-pushed
the
ubuntu-backport-gpg-key
branch
from
f768a62 to
f867561
Compare
bastelfreak
approved these changes
Nov 2, 2023
Collaborator
|
@kenyon let me know if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Same as #847 but for Ubuntu.
The gpg keys used to sign the Ubuntu repos, including backports, come with standard Ubuntu installations, so this Puppet module doesn't need to add any key.
Having this old key causes Puppet run failures for 20.04 and newer machines without Internet access, since it tries to fetch the key from the Internet.
Related Issues (if any)
#847