(BKR-1500) Dependency Cleanup #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Blocked on upstream changes in beaker. |
Contributor
Author
|
This branch passed spec and acceptance tests locally, when run against beaker/BKR-1500. So once voxpupuli/beaker#1536 is merged this one should pass against beaker/master and be safe to merge. |
Contributor
Author
|
Unblocked since upstream changes have merged. |
Contributor
Author
|
Jenkins, retest this please. |
Contributor
Author
|
Tests won't pass until upstream changes are released. |
Since this functionality is in beaker-puppet, its tests belong here too. Also removes a redundant install_utils from beaker-puppet acceptance and updates the install_package_on method in foss_utils to support platform SLES (which was updated in the redunadnt acceptance install_utils).
Since beaker no longer automatically includes beaker-puppet, we must explicitly include it in all test cases.
…andards Note that this doesn't follow beaker-template format exactly, due to unanticipated namespace conflicts in test_case.
And document this in README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers cleanup work related to removing beaker-puppet as a dependency from beaker. There were a number of leftover spec tests, duplicated helpers, and other assorted cruft that needed to be dealt with. Items that got left behind in beaker when this module was created:
Windows InstallUtils
FacterUtils spec tests
EZBakeUtils spec tests
Facter helpers, wrappers, and spec tests