Skip to content

Android: Added onSaveInstanceState #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pulsejet merged 6 commits into from
May 17, 2024
Merged

Android: Added onSaveInstanceState #1185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a320e7a
feat: Restore previous url when change to landscape and vise versa
May 10, 2024
10a0b90
reformat: Removed some semicolons
May 10, 2024
62a0e94
feat: Added full screen workaround
May 10, 2024
6af6074
feat: Added screenLayout into configChanges in manifest
May 10, 2024
b123e4d
restore: Removed saving of URL
May 12, 2024
33f9d8b
feat: Added more props into configChanges
May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
android:name=".MainActivity"
android:exported="true"
android:theme="@style/Theme.Memories.NoActionBar"
android:configChanges="orientation|screenSize">
android:configChanges="mcc|mnc|locale|touchscreen|keyboard|keyboardHidden|navigation|screenLayout|fontScale|uiMode|orientation|density|screenSize|smallestScreenSize">
<intent-filter>
<action android:name="android.intent.action.MAIN" />
<category android:name="android.intent.category.LAUNCHER" />
Expand Down
14 changes: 9 additions & 5 deletions android/app/src/main/java/gallery/memories/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ class MainActivity : AppCompatActivity() {
super.onCreate(savedInstanceState)
setContentView(binding.root)

// Set fullscreen mode if in landscape
val orientation = resources.configuration.orientation
setFullscreen(orientation == Configuration.ORIENTATION_LANDSCAPE)

// Restore last known look
restoreTheme()

Expand All @@ -99,9 +103,9 @@ class MainActivity : AppCompatActivity() {

override fun onDestroy() {
super.onDestroy()
binding.webview.removeAllViews();
binding.webview.removeAllViews()
binding.coordinator.removeAllViews()
binding.webview.destroy();
binding.webview.destroy()
nativex.destroy()
}

Expand Down Expand Up @@ -132,7 +136,7 @@ class MainActivity : AppCompatActivity() {
}

override fun onKeyDown(keyCode: Int, event: KeyEvent): Boolean {
if (event.getAction() == KeyEvent.ACTION_DOWN) {
if (event.action == KeyEvent.ACTION_DOWN) {
when (keyCode) {
KeyEvent.KEYCODE_BACK -> {
if (binding.webview.canGoBack()) {
Expand Down Expand Up @@ -268,7 +272,7 @@ class MainActivity : AppCompatActivity() {
if (BuildConfig.DEBUG) {
Toast.makeText(this, "Debugging enabled", Toast.LENGTH_SHORT).show()
binding.webview.clearCache(true)
WebView.setWebContentsDebuggingEnabled(true);
WebView.setWebContentsDebuggingEnabled(true)
}

// Welcome page or actual app
Expand All @@ -288,7 +292,7 @@ class MainActivity : AppCompatActivity() {
if (host != null) return true

// Load welcome page
binding.webview.loadUrl("file:///android_asset/welcome.html");
binding.webview.loadUrl("file:///android_asset/welcome.html")
return false
}

Expand Down