Skip to content

CI: Update Node, and use matrix with org var to set Node version for tests workflow#12

Open
DeeDeeG wants to merge 4 commits into
masterfrom
org-var-Node-version
Open

CI: Update Node, and use matrix with org var to set Node version for tests workflow#12
DeeDeeG wants to merge 4 commits into
masterfrom
org-var-Node-version

Conversation

@DeeDeeG

@DeeDeeG DeeDeeG commented May 6, 2026

Copy link
Copy Markdown
Member

Summary of changes

  • Update from Node 16 to Node 20 in publish.yml workflow, to loosely match core repo
  • Use the org variable to set Node version in tests.yml workflow

(Also, for the tests.yml workflow job matrix, keep a last known-good Node version in the matrix, so if things were ever to break due to the org variable changing, we have some paper trail of a known-good configuration.)

Alternative approaches

I left the Node version hard-coded in the publish workflow. (Albeit I did bump it from Node 16 to 20).

I didn't want to add complexity and potential friction to the publish.yml workflow. Sanity check testing could run on a matrix of multiple Node versions, I suppose... but that's really what the tests.yml workflow is for, IMO. Obviously the actual publish step should only run once.

(Most of the time, it should be the same major Node version in each matrix job anyway, if we're punctual about updating these various repos to sync to core...)

I'm open to adding a test matrix for the publish.yml workflow's first half if people really want it.

Verification

CI passes

DeeDeeG added 4 commits May 6, 2026 17:59
Also keep a last known-good Node version in the matrix, so if things
break when the org variable changes, we have some paper trail of
a known-good configuration.
Should make it easier to tell jobs apart,
now that we have a matrix with multiple job variants.
@DeeDeeG DeeDeeG changed the title CI: Update Node, and use matrix with org var to set Node version for tests workflow CI: Update Node, and use matrix with org var to set Node version for tests workflow May 6, 2026
@DeeDeeG DeeDeeG moved this from Primordial PRs to Ready in Repository Revitalization May 6, 2026

@confused-Techie confused-Techie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While personally, I'd prefer publication runs under the 'current' NodeJS version, there is value in having it happen in a known good version all the time, so not a blocker in the slightest.

This look great to me!

(Also was rather excited to see someone else add to the Repository Revitalization Board!!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

2 participants