Unsigned to signed conversion due to $floor().

[yvantor]

Is this $floor() operation needed? RegWidth and Cfg.IndexLength are defined as unsigned int, and the SV compiler automatically truncates fractional parts in integer divisions toward zero.
The explicit $floor() casts the ratio RegWidth/Cfg.IndexLength from integer to real, becoming thus signed. Synopsys raises an internal compiler error due to this.
Thanks ✌️

[alex96295]

@DiyouS @bluewww

I think this is from the LLC partitioning branch. I did not experience issues during synthesis. Regardless of the compilation error, we could improve the code to preserve the unsigned behavior

[DiyouS]

@DiyouS @bluewww

I think this is from the LLC partitioning branch. I did not experience issues during synthesis. Regardless of the compilation error, we could improve the code to preserve the unsigned behavior

I don't think I encountered problems during synthesis on it. But I can try to improve the code to avoid this issue

[yvantor]

@DiyouS @bluewww

I think this is from the LLC partitioning branch. I did not experience issues during synthesis. Regardless of the compilation error, we could improve the code to preserve the unsigned behavior

I don't think I encountered problems during synthesis on it. But I can try to improve the code to avoid this issue

If I do not go wrong I did change the code back in the day, I can point to the precise commit. I think different versions of DC or other tools can either trigger an issue or proceed with no errors, but in my opinion in general the cast to real is not functionally needed and the floor can be easily replaced by the simple division.

[alex96295]

@DiyouS @bluewww
I think this is from the LLC partitioning branch. I did not experience issues during synthesis. Regardless of the compilation error, we could improve the code to preserve the unsigned behavior

I don't think I encountered problems during synthesis on it. But I can try to improve the code to avoid this issue

If I do not go wrong I did change the code back in the day, I can point to the precise commit. I think different versions of DC or other tools can either trigger an issue or proceed with no errors, but in my opinion in general the cast to real is not functionally needed and the floor can be easily replaced by the simple division.

Yes please, so we can cherry pick it

[yvantor]

d79a00b