Skip to content

Updated swift dependency #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updated swift dependency #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a70cd8c
Updated swift dependency
marcin-cebo Nov 27, 2025
7e90727
Updated swift dependency
marcin-cebo Dec 1, 2025
c03dafe
Added missing params to HereNow for JS
marcin-cebo Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dokka = "2.0.0"
kotlinx_datetime = "0.6.2"
kotlinx_coroutines = "1.10.2"
pubnub_js = "10.1.0"
pubnub_swift = "9.3.5"
pubnub_swift = "10.1.0"

[libraries]
retrofit2 = { module = "com.squareup.retrofit2:retrofit", version.ref = "retrofit2" }
Expand Down
6 changes: 3 additions & 3 deletions ...n/pubnub-kotlin-api/src/appleMain/kotlin/com/pubnub/api/endpoints/presence/HereNow.ios.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import com.pubnub.kmp.onFailureHandler
import com.pubnub.kmp.onSuccessHandler
import com.pubnub.kmp.safeCast
import kotlinx.cinterop.ExperimentalForeignApi
import platform.Foundation.NSNumber

/**
* @see [PubNub.hereNow]
Expand All @@ -37,9 +38,8 @@ class HereNowImpl(
channelGroups = channelGroups,
includeState = includeState,
includeUUIDs = includeUUIDs,
// todo pass limit and offset once available
// limit = limit,
// offset = offset,
limit = limit.toLong(),
offset = offset?.let { NSNumber(it) },
onSuccess = callback.onSuccessHandler {
PNHereNowResult(
totalChannels = it?.totalChannels()?.toInt() ?: 0,
Expand Down
4 changes: 4 additions & 0 deletions pubnub-kotlin/pubnub-kotlin-api/src/jsMain/kotlin/Pubnub.d.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,10 @@ open external class PubNub(config: Any /* UUID | UserId */) {
var includeUUIDs: Boolean?

var includeState: Boolean?

var limit: Number?

var offset: Number?
}

interface HereNowOccupantData {
Expand Down
Loading