When subscribing to already subscribed channel or group should not resubscribe #384
Conversation
marcin-cebo
requested review from
jakub-grzesiowski,
jguz-pubnub,
kleewho and
parfeon
as code owners
| } | ||
|
|
||
| @Test | ||
| fun whenSubscribingToAlreadySubscribedChannelShouldNotResubscribeButShouldEmitSubscriptionChangedStatus() { |
There was a problem hiding this comment.
It's a pretty long name. What about shouldEmitSubscriptionChangedWhenAlreadySubscribed or something similar?
There was a problem hiding this comment.
shouldEmitSubscriptionChangedWhenAlreadySubscribed misses important part that we want to make sure that there is no resubscribe.
Name is pretty long but I think it serve the purpose of properly describing what the test does.
The test is complex and IMHO it is good that name describe its behaviour.
What do you think?
...tlin-impl/src/integrationTest/kotlin/com/pubnub/api/integration/SubscribeIntegrationTests.kt
Outdated
Show resolved
Hide resolved
...tlin-impl/src/integrationTest/kotlin/com/pubnub/api/integration/SubscribeIntegrationTests.kt
Outdated
Show resolved
Hide resolved
...tlin-impl/src/integrationTest/kotlin/com/pubnub/api/integration/SubscribeIntegrationTests.kt
Outdated
Show resolved
Hide resolved
...tlin-impl/src/integrationTest/kotlin/com/pubnub/api/integration/SubscribeIntegrationTests.kt
Outdated
Show resolved
Hide resolved
...tlin-impl/src/integrationTest/kotlin/com/pubnub/api/integration/SubscribeIntegrationTests.kt
Outdated
Show resolved
Hide resolved
| @Test | ||
| fun can_transit_from_RECEIVING_to_RECEIVING_when_there_is_SUBSCRIPTION_CHANGED_event() { | ||
| fun can_transit_from_RECEIVING_to_RECEIVING_when_there_is_SUBSCRIPTION_CHANGED_event_with_different_channels_and_groups() { | ||
| // given |
There was a problem hiding this comment.
I’d avoid adding comments like // given, // when, or // then. Instead, add comments only when they clarify something that is not obvious
There was a problem hiding this comment.
// given, // when, // then is convention that exist in many test in this SDK.
I would leave them for now.
Personally I find // given, // when, // then useful when reading tests.
…subscribe just emit SubscriptionChanged status.
marcin-cebo
force-pushed
the
mc/subscribeToTheSameChanel_noResubscribe
branch
from
68be032 to
d377ea8
Compare
2 participants
just emit SubscriptionChanged status.