Skip to content

Conversation

@RaviAnand111
Copy link
Contributor

fixes #819

The custom insert popover will disappear on pressing esc button while popover is open.

hey @NARUDESIGNS @TildaDares , can you please have a look at this pr
Thank You

@gitpod-io
Copy link

gitpod-io bot commented Feb 2, 2022

@NARUDESIGNS
Copy link
Collaborator

NARUDESIGNS commented Feb 2, 2022

@RaviAnand111 nice one!
I have a question, did you place the code woofmark-command click method?
Remember we only want to listen to these events after the custom-insert or table button has been clicked.

cc @TildaDares

@RaviAnand111
Copy link
Contributor Author

Yeah, totally forgot that part, I will do that and make a PR
Thanks

@RaviAnand111
Copy link
Contributor Author

2022-02-03.13-46-43.mp4

Here is the video of how the code is working,
Thanks

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @RaviAnand111

@NARUDESIGNS NARUDESIGNS changed the title Hiding Custom Insert Popover on Pressing button Hiding Custom Insert Popover on Pressing esc button Feb 4, 2022
@jywarren jywarren merged commit 7f42a14 into publiclab:main Feb 9, 2022
@jywarren
Copy link
Member

jywarren commented Feb 9, 2022

Merged this too! Congrats!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide Popover on pressing ESC button

4 participants