Skip to content

Conversation

@Sagarpreet
Copy link
Contributor

🔜

@gitpod-io
Copy link

gitpod-io bot commented Oct 13, 2020

@Sagarpreet Sagarpreet mentioned this pull request Oct 13, 2020
5 tasks
@Sagarpreet Sagarpreet mentioned this pull request Oct 13, 2020
14 tasks
@Sagarpreet
Copy link
Contributor Author

Changes done on top of @keshav234156 work:

  1. Title module uses new flex properties to center align.
  2. Boundaries of many buttons were not visible.
  3. Writing code had no css, works fine now.
  4. Remove <b> html tags.
  5. <i> font-awesome tag CSS was not working, works fine now.

@jywarren
Copy link
Member

This looks great! Is it ready for a merge? Thanks, @Sagarpreet !!!

@sagarpreet-chadha
Copy link
Contributor

Yes I have done sanity test of all features, feel free to try in gitpod 😄
We can merge then 👍

@jywarren jywarren merged commit cf1fc4a into publiclab:main Oct 13, 2020
@welcome
Copy link

welcome bot commented Oct 13, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days. In the meantime, can you tell us your Twitter handle so we can thank you properly?
Do join our weekly check-in to share your this week goal and the awesome work you did 😃.
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

This is awesome! Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants