Update to Bootstrap 4

[keshav234156]

Fix #508
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[gitpod-io]

[keshav234156]

@jywarren @NitinBhasneria @Shreyaa-s @Shulammite-Aso Please Review!!

[gitpod-io]

[gitpod-io]

[govindgoel]

The tests are failing due to some issues in bold.test.js

[cypherean]

I pulled your branch and the tests worked fine locally, anyone knows why this might be happening then?

[cypherean]

@keshav234156 do you mind if I make a testing commit in this branch?

[cypherean]

@NitinBhasneria were you able to run the ui-tests in gitpod? It's throwing an error when I tried.

[keshav234156]

@Shreyaa-s Yeah sure
For me as well tests are running locally well.

[keshav234156]

Even failing on https://travis-ci.com/github/publiclab/PublicLab.Editor/jobs/358505116

[cypherean]

That didn't work. The exact same code works for italic here but fails for bold. The last time I faced this the only difference b/w the two codes was an additional line and adding it worked.
Also, the italic and bold, both tests, failed for custom insert module test. This is strange. I'll try to analyse the behaviour of the tests again and if it persists we can try shifting them to woofmark?
Looping in @jywarren @Shulammite-Aso @NitinBhasneria , what do you all think?

[cypherean]

Sorry to go overboard on the testing, but on a slightly better note, one of the two previously failing bold tests is now passing.
The second test has passed, but the first one still fails. Restarting Travis.

[gitpod-io]

[cypherean]

Opened another pr for fixing this but all the tests passed there. I'll remove my commits from here.

[cypherean]

These tests passed for mine, Nitin's, Shulammite's PRs as well your recent PR on listing. Try rebasing this as Nitin suggested in #559 (review), resolve conflicts and push the changes. That might work.

[NitinBhasneria]

@keshav234156 solve the conflicts manually and run grunt build for solving the conflicts of dist files

[NitinBhasneria]

@NitinBhasneria were you able to run the ui-tests in gitpod? It's throwing an error when I tried.

same here.. bower process error

[cypherean]

@keshav234156 can I open #559 for testing purpose or do you have any plans for it?

[keshav234156]

@Shreyaa-s For me as well test are passing locally

[gitpod-io]