Add codespeed for continuous profiling (and sudoku) #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While pubgrub's performance is critical for both uv and cargo, there currently no benchmarking happening in the repository. [Codspeed](https://codspeed.io) runs our benchmarks with instruction counting, reporting more numbers with less variance than wall time. We get feedback on every PR, can see trends over time and there are flamegraphs and flamegraph diffs in the web view. We've made good experiences with it in both ruff and uv. With codspeed installed, we can start adding real-world benchmarks for uv and cargo to the pubgrub repo, and then optimize those.
konstin
changed the title
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
Eh2406
approved these changes
Nov 5, 2024
Member
Eh2406
left a comment
Eh2406
left a comment
There was a problem hiding this comment.
I will need to do some research about how to use it, but this is clearly an improvement!
|
|
||
| [dev-dependencies] | ||
| criterion = "0.5" | ||
| criterion = { version = "2.7.2", package = "codspeed-criterion-compat" } |
Member
There was a problem hiding this comment.
Does this change how I would run benchmarks locally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While pubgrub's performance is critical for both uv and cargo, there currently no benchmarking happening in the repository. Codspeed runs our benchmarks with instruction counting, reporting more numbers with less variance than wall time.
We get feedback on every PR, can see trends over time and there are flamegraphs and flamegraph diffs in the web view. We've made good experiences with it in both ruff and uv.
With codspeed installed, we can start adding real-world benchmarks for uv and cargo to the pubgrub repo, and then optimize those. Next to the large case example, i've added the synthetic but fun sudoku example.