Skip to content

Fixed URL issue for Public SSH keys #562 #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pspete merged 2 commits into from
Jun 8, 2025
Merged

Fixed URL issue for Public SSH keys #562 #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3f9dcd
Fixed URL issue for Public SSH keys
johannesconsulting Apr 23, 2025
55eafc0
Updated test URL
johannesconsulting Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tests/Add-PASPublicSSHKey.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ Describe $($PSCommandPath -Replace '.Tests.ps1') {

Assert-MockCalled Invoke-PASRestMethod -ParameterFilter {

$URI -eq "$($Script:psPASSession.BaseURI)/WebServices/PIMServices.svc/Users/SomeUser%40domain.com/AuthenticationMethods/SSHKeyAuthentication/AuthorizedKeys/"
$URI -eq "$($Script:psPASSession.BaseURI)/WebServices/PIMServices.svc/Users/SomeUser%40domain.com/AuthenticationMethods/SSHKeyAuthentication/AuthorizedKeys"

} -Times 1 -Exactly -Scope It

Expand Down
2 changes: 1 addition & 1 deletion Tests/Get-PASPublicSSHKey.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ Describe $($PSCommandPath -Replace '.Tests.ps1') {

Assert-MockCalled Invoke-PASRestMethod -ParameterFilter {

$URI -eq "$($Script:psPASSession.BaseURI)/WebServices/PIMServices.svc/Users/SomeUser%40domain.com/AuthenticationMethods/SSHKeyAuthentication/AuthorizedKeys/"
$URI -eq "$($Script:psPASSession.BaseURI)/WebServices/PIMServices.svc/Users/SomeUser%40domain.com/AuthenticationMethods/SSHKeyAuthentication/AuthorizedKeys"

} -Times 1 -Exactly -Scope It

Expand Down
2 changes: 1 addition & 1 deletion Tests/Remove-PASPublicSSHKey.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ Describe $($PSCommandPath -Replace '.Tests.ps1') {

Assert-MockCalled Invoke-PASRestMethod -ParameterFilter {

$URI -eq "$($Script:psPASSession.BaseURI)/WebServices/PIMServices.svc/Users/SomeUser%40domain.com/AuthenticationMethods/SSHKeyAuthentication/AuthorizedKeys/SomeKeyID/"
$URI -eq "$($Script:psPASSession.BaseURI)/WebServices/PIMServices.svc/Users/SomeUser%40domain.com/AuthenticationMethods/SSHKeyAuthentication/AuthorizedKeys/SomeKeyID"

} -Times 1 -Exactly -Scope It

Expand Down
2 changes: 1 addition & 1 deletion psPAS/Functions/Authentication/Add-PASPublicSSHKey.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function Add-PASPublicSSHKey {
#Create URL to endpoint for request
$URI = "$($psPASSession.BaseURI)/WebServices/PIMServices.svc/Users/$($UserName |

Get-EscapedString)/AuthenticationMethods/SSHKeyAuthentication/AuthorizedKeys/"
Get-EscapedString)/AuthenticationMethods/SSHKeyAuthentication/AuthorizedKeys"

#create request body
$Body = @{
Expand Down
2 changes: 1 addition & 1 deletion psPAS/Functions/Authentication/Get-PASPublicSSHKey.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function Get-PASPublicSSHKey {
#Create URL for request
$URI = "$($psPASSession.BaseURI)/WebServices/PIMServices.svc/Users/$($UserName |

Get-EscapedString)/AuthenticationMethods/SSHKeyAuthentication/AuthorizedKeys/"
Get-EscapedString)/AuthenticationMethods/SSHKeyAuthentication/AuthorizedKeys"

#Send request to web service
$result = Invoke-PASRestMethod -Uri $URI -Method GET
Expand Down
2 changes: 1 addition & 1 deletion psPAS/Functions/Authentication/Remove-PASPublicSSHKey.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ function Remove-PASPublicSSHKey {
#Create URL string for request
$URI = "$($psPASSession.BaseURI)/WebServices/PIMServices.svc/Users/$($UserName |

Get-EscapedString)/AuthenticationMethods/SSHKeyAuthentication/AuthorizedKeys/$KeyID/"
Get-EscapedString)/AuthenticationMethods/SSHKeyAuthentication/AuthorizedKeys/$KeyID"

if ($PSCmdlet.ShouldProcess($KeyID, 'Delete Public SSH Key')) {

Expand Down