Fix schema generation error caused by new click version #4750
Conversation
Not sure on the policy for updating versions, so to cope with the new click 8.3.0 version I used some code from psf#4577 for version conditional behavior. When >= 8.3.0, unset defaults are now the special UNSET sentinal instead of None. Hopefully nothing breaks on the click._utils usage since it's an _ module, might have to find a different solution if it does.
for more information, see https://pre-commit.ci
|
Looks like this does have mypy issues despite working to fix the issue |
| result[name]["description"] = param.help | ||
|
|
||
| if param.default is not None and not param.multiple: | ||
| if Version(imp_version("click")) >= Version("8.3.0"): |
There was a problem hiding this comment.
Could also do something like hasattr(click, "_utils") and hasattr(click._utils, "UNSET"), though I guess it will still need a mypy type ignore. The current code is fine with me too.
Normally I'd be concerned about breaking future users if click removes or moves the private object later, but this is just an internal script; if it breaks later we can just fix it and users won't be affected.
There was a problem hiding this comment.
I searched around for a while but I don't see a better way of doing it that doesn't involve a mypy ignore, so 🤷.
I like the current code since it says that whatever the problem/change is, it starts in click 8.3.0.
3 participants
Description
Not sure on the policy for updating versions, so to cope with the new click 8.3.0 version I used some code from #4577 for version conditional behavior. When >= 8.3.0, unset defaults are now the special UNSET sentinal instead of None. Hopefully nothing breaks on the click._utils usage since it's an _ module, might have to find a different solution if it does.
Checklist - did you ...
--previewstyle, following thestability policy?
CHANGES.mdif necessary?