Skip to content

Update python image version and reduce size for gallery docker image #4686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cobaltt7 merged 4 commits into from
Jun 15, 2025
Merged

Update python image version and reduce size for gallery docker image #4686

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4624e0f
Update python image version and reduce size
huisman Jun 7, 2025
b9cf33e
Use python base image without minor version
huisman Jun 14, 2025
6990a8a
Update CHANGES.md
huisman Jun 14, 2025
633a3df
Merge branch 'main' into patch-1
cooperlees Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions gallery/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
FROM python:3.8.2-slim
FROM python:3.13-slim
Copy link
Copy Markdown
Collaborator

@cooperlees cooperlees Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can go either way here - I wonder if we want to just follow python:3-slim here if it exists? I guess ti depends how recent it's kept - I would hope latest stable major - i.e. 3.13 at the moment ...

Copy link
Copy Markdown
Contributor Author

@huisman huisman Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python:3-slim exists and it is kept up-to-date, but I haven't found an explicit statement on whether it follows the latest stable minor or major version.

I think in this case it might be worth it to use python:3-slim. It would have prevented the image from not working due to the type hinting. My guess is that it would prevent more issues than pinning a specific version would prevent(especially since this image does not appear to be used very often.)


# note: a single RUN to avoid too many image layers being produced
RUN apt-get update \
&& apt-get upgrade -y \
&& apt-get install git apt-utils -y \
&& apt-get install git apt-utils -y --no-install-recommends\
&& git config --global user.email "[email protected]" \
&& git config --global user.name "Gallery/Black"
&& git config --global user.name "Gallery/Black" \
&& rm -rf /var/lib/apt/lists/*

COPY gallery.py /
ENTRYPOINT ["python", "/gallery.py"]
Loading