Pickle raw tuples in FileData cache#3877
Merged
hauntsaninja merged 4 commits intopsf:mainfrom Sep 10, 2023
Merged
Conversation
Collaborator
Author
|
Discussion and perf numbers in #3867 (comment). I also tried pickling and pickling raw tuples is ~2x as fast as pickling NamedTuples for me: These numbers are without mypyc compilation so they may not completely reflect reality, but if anything I'd expect mypyc to magnify the difference (because the raw tuple version does more work in user code that would be sped up by mypyc, and the NamedTuple version does more work inside |
cdce8p
approved these changes
Sep 10, 2023
hauntsaninja
approved these changes
Sep 10, 2023
Collaborator
hauntsaninja
left a comment
There was a problem hiding this comment.
(can also use pickle protocol 5 if we want to now)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.