Consistently format async statements similar to their non-async version.#3609
Merged
JelleZijlstra merged 3 commits intopsf:mainfrom Mar 16, 2023
Merged
Consistently format async statements similar to their non-async version.#3609JelleZijlstra merged 3 commits intopsf:mainfrom
JelleZijlstra merged 3 commits intopsf:mainfrom
Conversation
JelleZijlstra
approved these changes
Mar 16, 2023
Collaborator
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looks good, thanks! (apart from two minor things I commented)
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
copybara-service bot
pushed a commit
to google/pyink
that referenced
this pull request
Mar 17, 2023
…n unchanged lines might have their leading space normalized. This is also required for the new async handling introduced in psf#3609 PiperOrigin-RevId: 517517272
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3591
In addition, other formatting to non-async version of the corresponding statement is also applied, such as removing unnecessary parens.
Checklist - did you ...
CHANGES.mdif necessary?